add php 8.4 support (#11)

emmachughes · web-flow · commit af41490a0c70 · 2024-11-21T13:26:48.000+01:00
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -10,7 +10,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php-versions: ['8.2', '8.3']
+                php-versions: ['8.2', '8.3', '8.4']
 
         steps:
             -   name: Checkout
diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@ Create custom content types for [Edlib](https://edlib.com/).
 
 ## Requirements
 
-* PHP 8.2 or 8.3
+* PHP 8.2, 8.3 or 8.4
 
 ## Installation
 
diff --git a/composer.json b/composer.json
@@ -25,7 +25,7 @@
         }
     },
     "require": {
-        "php": "8.2.*|8.3.*",
+        "php": "8.2.*|8.3.*|8.4.*",
         "psr/clock": "^1.0",
         "psr/clock-implementation": "^1.0",
         "psr/simple-cache": "^1.0|^2.0|^3.0",
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -3,7 +3,8 @@
          bootstrap="vendor/autoload.php"
          colors="true"
          cacheDirectory=".phpunit.cache"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.4/phpunit.xsd">
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.4/phpunit.xsd"
+         displayDetailsOnTestsThatTriggerDeprecations="true">
     <coverage />
 
     <testsuites>
diff --git a/tests/Lti/Edlib/EdlibContentItemsSerializerTest.php b/tests/Lti/Edlib/EdlibContentItemsSerializerTest.php
@@ -10,6 +10,8 @@
 
 final class EdlibContentItemsSerializerTest extends TestCase
 {
+    private EdlibContentItemsSerializer $serializer;
+
     protected function setUp(): void
     {
         $this->serializer = new EdlibContentItemsSerializer();

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`}`
`26`	`26`	`},`
`27`	`27`	`"require": {`
`28`		`- "php": "8.2.\|8.3.",`
	`28`	`+ "php": "8.2.\|8.3.\|8.4.*",`
`29`	`29`	`"psr/clock": "^1.0",`
`30`	`30`	`"psr/clock-implementation": "^1.0",`
`31`	`31`	`"psr/simple-cache": "^1.0\|^2.0\|^3.0",`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@`
`10`	`10`
`11`	`11`	`final class EdlibContentItemsSerializerTest extends TestCase`
`12`	`12`	`{`
	`13`	`+ private EdlibContentItemsSerializer $serializer;`
	`14`	`+`
`13`	`15`	`protected function setUp(): void`
`14`	`16`	`{`
`15`	`17`	`$this->serializer = new EdlibContentItemsSerializer();`