CR adjustments

Author: chrieinv

src/Lti/Lti11/Mapper/DeepLinking/ScoreConstraintsMapper.php

@@ -5,7 +5,7 @@
 use Cerpus\EdlibResourceKit\Lti\Lti11\Context\DeepLinkingProps as Prop;
 use Cerpus\EdlibResourceKit\Lti\Message\DeepLinking\ScoreConstraints;
 
-class ScoreConstraintsMapper implements ScoreConstraintsMapperInterface
+final readonly class ScoreConstraintsMapper implements ScoreConstraintsMapperInterface
 {
     public function map(array $data): ScoreConstraints|null
     {

src/Lti/Lti11/Serializer/DeepLinking/LineItemSerializer.php

@@ -10,7 +10,7 @@
 final readonly class LineItemSerializer implements LineItemSerializerInterface
 {
     public function __construct(
-        private ScoreConstraintsSerializer $scoreConstraintsSerializer = new ScoreConstraintsSerializer(),
+        private ScoreConstraintsSerializerInterface $scoreConstraintsSerializer = new ScoreConstraintsSerializer(),
     ) {
     }
 

src/Lti/Message/DeepLinking/LineItem.php

@@ -2,10 +2,10 @@
 
 namespace Cerpus\EdlibResourceKit\Lti\Message\DeepLinking;
 
-final readonly class LineItem
+class LineItem
 {
     public function __construct(
-        private ScoreConstraints|null $scoreConstraints = null,
+        private readonly ScoreConstraints|null $scoreConstraints = null,
     ) {
     }
 

src/Lti/Message/DeepLinking/ScoreConstraints.php

@@ -4,11 +4,11 @@
 
 namespace Cerpus\EdlibResourceKit\Lti\Message\DeepLinking;
 
-final readonly class ScoreConstraints
+class ScoreConstraints
 {
     public function __construct(
-        private float|null $normalMaximum = null,
-        private float|null $extraCreditMaximum = null,
+        private readonly float|null $normalMaximum = null,
+        private readonly float|null $extraCreditMaximum = null,
     ) {
     }