Fix upmap-remapped script to avoid BlockingIOError #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BlockingIOError issues observed when switching from Python 3.9.2 to 3.11.2, great fix! |
dvanders
reviewed
Feb 20, 2025
tools/upmap/upmap-remapped.py
Outdated
| @@ -40,6 +40,10 @@ | |||
|
|
|||
| import json, subprocess, sys | |||
|
|
|||
| def get_command_output(command): | |||
| result = subprocess.run(command, capture_output=True, text=True, check=True, shell=True) | |||
There was a problem hiding this comment.
@Taadas thanks for this PR.
text=True will break compat with Python < 3.7 https://stackoverflow.com/questions/52663518/python-subprocess-popen-doesnt-take-text-argument
universal_newlines=True should work for old and current Pythons.
There was a problem hiding this comment.
Good catch, changed to universal_newlines.
Before this fix, the script sometimes would raise a BlockingIOError when trying to execute `subprocess.getoutput`. This was due to the fact that the script blocked the standard output of the subprocess, which caused the error. This fix changes the script to use `subprocess.run` instead of `subprocess.getoutput` to avoid the error.
Taadas
force-pushed
the
bugfix/upmap-remapped-io-error
branch
from
e5926dc to
b579703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the script sometimes would raise a BlockingIOError when trying to execute
subprocess.getoutput:This was due to the fact that the script blocked the standard output of the subprocess, which caused the error. This fix changes the script to use
subprocess.runinstead ofsubprocess.getoutputto avoid the error.