Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spelling REDUCTED -> REDACTED, found by codespell #446

Merged
merged 3 commits into from
Feb 23, 2025

Conversation

Avev
Copy link
Contributor

@Avev Avev commented Feb 23, 2025

Fixed spelling errors in lines 205 and 251 REDUCTED -> REDACTED, found by codespell.
image

@Avev Avev requested a review from Nusnus as a code owner February 23, 2025 15:35
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds a new contributor and fixes documentation formatting issues in pytest-celery.

  • Date format in /CONTRIBUTORS.txt needs to be standardized to match existing format (YYYY/DD/MM)
  • Future date 2025/23/02 in /CONTRIBUTORS.txt should be corrected to current date
  • Fixed spelling of "REDACTED" (was "REDUCTED") in /docs/getting-started/first-steps.rst log examples

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.80%. Comparing base (9995ab4) to head (0bec019).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   23.80%   23.80%           
=======================================
  Files          41       41           
  Lines        1294     1294           
  Branches       94       94           
=======================================
  Hits          308      308           
  Misses        959      959           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor the PR description text and explain where you got this error from.
You may add a link or a screenshot or both to the PR.

If someone looks at this PR in the future, it should be easy and fast to understand what was changed without reviewing all of the actual changes.
On that note, improve the PR title to be more descriptive, for example “Fixed spelling of X -> Y, found by codespell"

@Avev Avev changed the title Spelling fix Fixed spelling REDUCTED -> REDACTED, found by codespell Feb 23, 2025
@Nusnus
Copy link
Member

Nusnus commented Feb 23, 2025

@greptileai

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes to comment on since the last review. The previous reviews have already covered the key points about standardizing the date format, correcting the future date, and fixing the spelling error. The PR description and title have been updated as requested in the most recent review.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Nusnus Nusnus merged commit 94fc524 into celery:main Feb 23, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants