Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: fix the "=+" #7

Open
cederom opened this issue Jun 14, 2017 · 0 comments
Open

TODO: fix the "=+" #7

cederom opened this issue Jun 14, 2017 · 0 comments
Labels

Comments

@cederom
Copy link
Owner

cederom commented Jun 14, 2017

As reported by @MemphisCZ in #6:

Hi @cederom

I using your lib in one of my project and found maybe a mistyping in your source code.
For example in file libswd_cmdq.c line 243:

res=libswd_drv_transmit(libswdctx, cmd);
if (res<0) return res;
cmdcnt=+res;

the cmdcnt will then hold only the last result of res not the sum of them, which will emit in some cases problems.
To fix all these kind of problems, maybe it would be better to find all "=+" across the libswd source code and change it to "+="

Best regards,
Tomas Kamenicky / @MemphisCZ

@cederom cederom added the bug label Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant