Fix scraper not filling input when looking for INGENIERIA EN COMPUTACION
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquintomas2003
requested review from
EmilioCristalli and
santiagorodriguez96
joaquintomas2003
changed the title
joaquintomas2003
changed the title
INGENIERIA EN COMPUTACION
lib/scraper/bedelias.rb
Outdated
Comment on lines
70
to
72
| if page.has_css?('.ui-widget-overlay', wait: 5) | ||
| page.assert_no_selector('.ui-widget-overlay') | ||
| end |
There was a problem hiding this comment.
Me gusta la idea! Primero preguntás si está el modal y aguantás un rato hasta que aparezca. Si aparece esperás a que desaparezca. Si no aparece, quizás significa que ya apareció y se fue antes de hacer el chequeo por lo que seguirías de largo y en ese caso, en teoría, la página debería estar lista para usar el input del buscador.
La única pregunta que tengo es, es necesario el wait? Creo que por defecto Capybara espera dos segundos a que aparezca
There was a problem hiding this comment.
buena observación, no había necesidad de agregarlo :)
joaquintomas2003
force-pushed
the
jt--fix_scraper_not_filling_input
branch
from
3c585ec to
58f5ead
Compare
santiagorodriguez96
approved these changes
Feb 1, 2025
EmilioCristalli
approved these changes
Feb 1, 2025
lib/scraper/bedelias.rb
Outdated
Comment on lines
70
to
72
| if page.has_css?('.ui-widget-overlay') | ||
| page.assert_no_selector('.ui-widget-overlay') | ||
| end |
There was a problem hiding this comment.
Suggested change
| if page.has_css?('.ui-widget-overlay') | |
| page.assert_no_selector('.ui-widget-overlay') | |
| end | |
| if has_css?('.ui-widget-overlay') | |
| assert_no_selector('.ui-widget-overlay') | |
| end |
joaquintomas2003
force-pushed
the
jt--fix_scraper_not_filling_input
branch
from
58f5ead to
3902cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El scraper esta teniendo un comportamiento flaky, en el que el input de buscar la carrera muchas veces no se llena.
El motivo es la aparición de este widget de que la pagina esta cargando:
Esperar a saber que estamos en la pagina de buscar carreras haciendo find('span', text: 'Planes de estudio - FING').
Esto lo hacemos para no matchear con el widget de la pagina anterior.
Esperar a ver si aparece el widget
.ui-widget-overlay, y hasta que no se vaya no usar el input.