upload scraper screenshots in case of failure #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquintomas2003
requested review from
EmilioCristalli and
santiagorodriguez96
joaquintomas2003
force-pushed
the
jt--save_scraper_screenshots
branch
from
adb8dc9 to
4867996
Compare
| @@ -19,7 +19,7 @@ def scrape | |||
| Capybara.configure do |config| | |||
| config.default_driver = ENV["HEADLESS"] == "false" ? :selenium_chrome : :selenium_chrome_headless | |||
| config.run_server = false | |||
| config.save_path = "tmp" | |||
| config.save_path = "tmp/capybara" | |||
There was a problem hiding this comment.
just to confirm, do the screenshots we take in the rescue work for the parts of the code that we have multiple threads?
There was a problem hiding this comment.
buena pregunta
lo hice fallar durante el process_prerequisites_slice y parece funcionar 👍
https://github.com/cedarcode/mi_carrera/actions/runs/13088675841/job/36522842270
EmilioCristalli
approved these changes
Feb 1, 2025
.github/workflows/scraper.yml
Outdated
| with: | ||
| name: scraper_screenshot | ||
| path: ./tmp/capybara | ||
| retention-days: 2 |
There was a problem hiding this comment.
Suggested change
| retention-days: 2 | |
| retention-days: 5 |
pongámosle unos días más por si falla un fin de semana por ejemplo y no lo vemos enseguida
joaquintomas2003
force-pushed
the
jt--save_scraper_screenshots
branch
from
4867996 to
f4f2663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.