Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HierarchyNotRespected validation error #638

Open
2 tasks
khieta opened this issue Feb 13, 2024 · 2 comments · May be fixed by #1355
Open
2 tasks

Remove HierarchyNotRespected validation error #638

khieta opened this issue Feb 13, 2024 · 2 comments · May be fixed by #1355
Labels
papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request

Comments

@khieta
Copy link
Contributor

khieta commented Feb 13, 2024

Describe the improvement you'd like to request

According to this comment we return the HierarchyNotRespected error in some cases where we could soundly type an expression as False. This error was introduced (IIRC) to avoid having to update the Dafny type soundness proof.

Now that we've switched to using Lean, and tweaked the validation property being tested, I wonder if we could remove this error variant.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@khieta khieta added pending-review A Cedar maintainer has looked at this, but believes it needs review by more of the core team internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice labels Feb 13, 2024
@khieta khieta mentioned this issue Feb 13, 2024
3 tasks
@john-h-kastner-aws
Copy link
Contributor

May depend on #539, but with that we definitely can. Haven't thought about what we can do given your tweak to the property being tested.

@john-h-kastner-aws john-h-kastner-aws added backlog and removed pending-review A Cedar maintainer has looked at this, but believes it needs review by more of the core team labels Feb 19, 2024
@sarahcec sarahcec added breaking-change This is (likely) a breaking change and removed breaking-change This is (likely) a breaking change labels Mar 5, 2024
@mwhicks1
Copy link
Contributor

mwhicks1 commented Apr 3, 2024

I have a customer use-case that would benefit from this change. It makes conceptual sense to do this -- impossible policies due to in checks not being respected will be flagged by another mechanism.

@john-h-kastner-aws john-h-kastner-aws added papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request and removed internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice backlog labels Oct 1, 2024
@cdisselkoen cdisselkoen linked a pull request Dec 5, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
papercut Small annoyances in the Cedar SDK. Lower priority fixes than bugs. Smaller than a fature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants