Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic safety script could be replaced with official tooling #1512

Open
1 of 2 tasks
adpaco-aws opened this issue Feb 28, 2025 · 0 comments
Open
1 of 2 tasks

Panic safety script could be replaced with official tooling #1512

adpaco-aws opened this issue Feb 28, 2025 · 0 comments
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@adpaco-aws
Copy link
Contributor

Describe the improvement you'd like to request

@cdisselkoen noted that we could probably replace panic_safety.sh with the new clippy tools available in Rust 1.81 including the ability to do #[allow(clippy::expect_used, reason = "...")] and an option we can enforce on our workspace’s Cargo.toml to allow_attributes_without_reason = deny.

If this official tooling allows us to completely replace the panic safety script, we should do it.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@adpaco-aws adpaco-aws added internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Feb 28, 2025
@cdisselkoen cdisselkoen removed the pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Development

No branches or pull requests

2 participants