Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cases for datetime types in extExprToValue #568

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Cases for datetime types in extExprToValue #568

merged 1 commit into from
Mar 5, 2025

Conversation

adpaco-aws
Copy link
Contributor

Issue #, if available:

Description of changes: We are missing cases for datetime types in the extExprToValue function. Without them, DRT crashes on at least one target with an error like:

Error: evaluateReq: failed to parse input: offset 95: exprToValue: unexpected extension value
Cedar.Spec.Expr.call (Cedar.Spec.ExtFun.datetime) [Cedar.Spec.Expr.lit (Cedar.Spec.Prim.string "0000-01-01")]

@adpaco-aws
Missing datetime cases in extExprToValue
add222a 
Signed-off-by: Adrian Palacios <accorell@amazon.com>
@adpaco-aws adpaco-aws merged commit 582a8cb into cedar-policy:main Mar 5, 2025
6 checks passed
john-h-kastner-aws added a commit that referenced this pull request Mar 6, 2025
@john-h-kastner-aws
Squashed commit of the following:
b492c16 
commit 5e64bec
Author: John Kastner <jkastner@amazon.com>
Date:   Thu Mar 6 18:56:34 2025 +0000

    Extend typechecker inversion lemma for type annotation

    Signed-off-by: John Kastner <jkastner@amazon.com>

commit a33231a
Author: shaobo-he-aws <130499339+shaobo-he-aws@users.noreply.github.com>
Date:   Thu Mar 6 07:22:38 2025 -0800

    TPE Lean model (#548)

    Signed-off-by: Shaobo He <shaobohe@amazon.com>

commit 582a8cb
Author: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Date:   Wed Mar 5 11:48:14 2025 -0500

    Cases for `datetime` types in `extExprToValue` (#568)

    Signed-off-by: Adrian Palacios <accorell@amazon.com>

commit ee3715f
Author: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Date:   Tue Mar 4 16:05:17 2025 -0500

    Add types and methods from `datetime` extension to parsers (#565)

    Signed-off-by: Adrian Palacios <accorell@amazon.com>

commit 183be85
Author: Craig Disselkoen <cdiss@amazon.com>
Date:   Tue Mar 4 13:01:15 2025 -0800

    [lean] remove JSON deserializer for internal JSON format (#567)

    Signed-off-by: Craig Disselkoen <cdiss@amazon.com>

commit 71e13dc
Author: Craig Disselkoen <cdiss@amazon.com>
Date:   Tue Mar 4 12:20:55 2025 -0800

    remove partial-auth and partial-eval DRT targets (#566)

    Signed-off-by: Craig Disselkoen <cdiss@amazon.com>

commit 434f09f
Author: Craig Disselkoen <cdiss@amazon.com>
Date:   Tue Mar 4 06:04:25 2025 -0800

    use Protobuf for additional DRT targets (#562)

    Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdisselkoen cdisselkoen cdisselkoen approved these changes

@chaluli chaluli chaluli approved these changes

@john-h-kastner-aws john-h-kastner-aws Awaiting requested review from john-h-kastner-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adpaco-aws @cdisselkoen @chaluli