remove partial-auth and partial-eval DRT targets #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
4 tasks
john-h-kastner-aws
approved these changes
Mar 4, 2025
8 tasks
|
CI failing until we merge cedar-policy/cedar#1521 |
shaobo-he-aws
approved these changes
Mar 4, 2025
john-h-kastner-aws
added a commit
that referenced
this pull request
Mar 6, 2025
commit 5e64bec Author: John Kastner <jkastner@amazon.com> Date: Thu Mar 6 18:56:34 2025 +0000 Extend typechecker inversion lemma for type annotation Signed-off-by: John Kastner <jkastner@amazon.com> commit a33231a Author: shaobo-he-aws <130499339+shaobo-he-aws@users.noreply.github.com> Date: Thu Mar 6 07:22:38 2025 -0800 TPE Lean model (#548) Signed-off-by: Shaobo He <shaobohe@amazon.com> commit 582a8cb Author: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com> Date: Wed Mar 5 11:48:14 2025 -0500 Cases for `datetime` types in `extExprToValue` (#568) Signed-off-by: Adrian Palacios <accorell@amazon.com> commit ee3715f Author: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com> Date: Tue Mar 4 16:05:17 2025 -0500 Add types and methods from `datetime` extension to parsers (#565) Signed-off-by: Adrian Palacios <accorell@amazon.com> commit 183be85 Author: Craig Disselkoen <cdiss@amazon.com> Date: Tue Mar 4 13:01:15 2025 -0800 [lean] remove JSON deserializer for internal JSON format (#567) Signed-off-by: Craig Disselkoen <cdiss@amazon.com> commit 71e13dc Author: Craig Disselkoen <cdiss@amazon.com> Date: Tue Mar 4 12:20:55 2025 -0800 remove partial-auth and partial-eval DRT targets (#566) Signed-off-by: Craig Disselkoen <cdiss@amazon.com> commit 434f09f Author: Craig Disselkoen <cdiss@amazon.com> Date: Tue Mar 4 06:04:25 2025 -0800 use Protobuf for additional DRT targets (#562) Signed-off-by: Craig Disselkoen <cdiss@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code associated with the partial-auth and partial-eval DRT targets. These targets were completely unimplemented on the Lean side, as Lean partial evaluation is no longer present on
main. Also, these targets are the last remaining users of the internal/undocumented JSON format for Coreasttypes. If/when we want to reintroduce partial-auth and partial-eval DRT, we can/should do it with Protobufs instead of the current approach. For now, this PR will enable us to finally remove the old JSON ser/de code for the internal/undocumented JSON format (planned as a followup PR).