Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable datetime generation #560

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Enable datetime generation #560

merged 1 commit into from
Mar 3, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

This reverts commit 3681ffc.

Issue #, if available:

Description of changes:

cdisselkoen
cdisselkoen approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@cdisselkoen cdisselkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternately, we could leave the flag and just set it to true in all targets. No strong opinion from me.

adpaco-aws
adpaco-aws approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is fine. If we really want to control generation like this, we should probably have a more general solution including other extensions.

If I'm not mistaken, this will require follow-up PRs somewhere else. Don't know where.

@shaobo-he-aws shaobo-he-aws merged commit 7483417 into main Mar 3, 2025
5 of 6 checks passed
@shaobo-he-aws shaobo-he-aws deleted the re-enable-datetime branch March 3, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdisselkoen cdisselkoen cdisselkoen approved these changes

@adpaco-aws adpaco-aws adpaco-aws approved these changes

@john-h-kastner-aws john-h-kastner-aws Awaiting requested review from john-h-kastner-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaobo-he-aws @cdisselkoen @adpaco-aws