Add Expr.ext to contain extension values
#546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
emina
reviewed
Feb 19, 2025
| @@ -181,4 +186,108 @@ theorem policy_produces_bool_or_error (p : Policy) (request : Request) (entities | |||
| unfold Policy.toExpr | |||
| apply and_produces_bool_or_error | |||
|
|
|||
| def Value.toExpr : Value → Expr | |||
There was a problem hiding this comment.
Let's move these definitions into Cedar/Thm/PE/Basic.lean, and then move all proofs related to them to modules in Cedar/Thm/PE/.
Basically, we want to keep definitions and theorems related to PE in its own folder, similar to the definitions and proofs for validation.
There was a problem hiding this comment.
You can avoid the termination proof if you rewrite the definition as follows:
def Value.toExpr : Value → Expr
| .prim p => .lit p
| .ext e => .ext e
| .set (.mk vs) => .set (vs.map₁ λ ⟨v, _⟩ => Value.toExpr v)
| .record (.mk avs) => .record (avs.attach₃.map λ ⟨(k, v), _⟩ => (k, Value.toExpr v))
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: