Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable error comparison in DRT #208

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

cdisselkoen
Copy link
Contributor

Following #206, the Lean engine actually returns errors (or at least, the ids of erroring policies). DRT should properly compare this against the errors produced by the Rust.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cdisselkoen cdisselkoen marked this pull request as ready for review February 1, 2024 19:25
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Making it configurable will be more flexible in the future too. Think I might use this to unify the integration testing / DRT harness further.

@cdisselkoen cdisselkoen merged commit e39eb2b into main Feb 1, 2024
3 checks passed
@cdisselkoen cdisselkoen deleted the cdisselkoen/drt-errors branch February 1, 2024 19:33
@cdisselkoen cdisselkoen mentioned this pull request Feb 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants