[2.4.x] add note on .NET installation to README #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khieta
approved these changes
Jan 24, 2024
khieta
reviewed
Jan 24, 2024
Comment on lines
16
to
+17
| * Install Dafny 4.0, following the instructions [here](https://github.com/dafny-lang/dafny/wiki/INSTALL). Our proofs expect Z3 version 4.12.1, so if you have another copy of Z3 installed locally, you may need to adjust your PATH. | ||
| * Note that our Makefile also expects the .NET SDK and `dotnet` executable, version 6.0.x, available on your PATH. You can download the .NET SDK 6.0 from [here](https://dotnet.microsoft.com/en-us/download/dotnet/6.0). |
There was a problem hiding this comment.
Suggested change
| * Install Dafny 4.0, following the instructions [here](https://github.com/dafny-lang/dafny/wiki/INSTALL). Our proofs expect Z3 version 4.12.1, so if you have another copy of Z3 installed locally, you may need to adjust your PATH. | |
| * Note that our Makefile also expects the .NET SDK and `dotnet` executable, version 6.0.x, available on your PATH. You can download the .NET SDK 6.0 from [here](https://dotnet.microsoft.com/en-us/download/dotnet/6.0). | |
| * Install Dafny and its dependencies, following the instructions [here](https://github.com/dafny-lang/dafny/wiki/INSTALL). Note that our proofs expect Z3 version 4.12.1, so if you have another copy of Z3 installed locally, you may need to adjust your PATH. |
Just noticed that the linked installation instructions say to install .NET.
There was a problem hiding this comment.
Yes but the linked installation instructions don't specify that you need the .NET SDK (not just the .NET runtime) and don't specify that the dotnet executable must be on your PATH. Although possibly we should just submit that patch to the linked instructions rather than here
shaobo-he-aws
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note to the README about installation of .NET which is required for Dafny.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.