Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run corpus tests through Lean implementation #226

Closed
2 tasks
khieta opened this issue Feb 21, 2024 · 0 comments · Fixed by #253
Closed
2 tasks

Run corpus tests through Lean implementation #226

khieta opened this issue Feb 21, 2024 · 0 comments · Fixed by #253
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@khieta
Copy link
Contributor

khieta commented Feb 21, 2024

Category

Lean formalization

Describe the feature you'd like to request

The Lean implementation is tested in CI against the handwritten integration tests in cedar/cedar-integration-tests/tests. It is not currently tested against the autogenerated corpus tests since the Lean & Rust validators have different precision, potentially leading to different validation results (see #210). This behavior difference does not affect the handwritten tests, but will (likely) affect the autogenerated tests.

To get the Lean formalization running on the corpus tests, we'll need to either update the testing harness to optionally ignore validation differences, or get the Rust & Lean code to parity.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@khieta khieta added backlog internal-improvement Refactoring, performance improvement, or other non-breaking change labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant