chore: update workflowNodeVersion to lts/* #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
|
Generally, LGTM. |
sumupitchayan
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
upgrade-configurationworkflows are failing forcdk8s-cli: https://github.com/cdk8s-team/cdk8s-cli/actions/runs/6998871953.This is due to us editing the workflow file and adding
lts/*based on step number. This step number changes if we haveworkflow bootstrap steps, which would precede node step. This results in us editing the file at the incorrect spot and lead to an incorrect workflow yaml file.Instead of editing the workflow file and relying on the step number to be correct, I am instead adding this to
workflowNodeVersionproperty of projen projects.