Skip to content

Commit

Permalink
🐛 Fix creation of Location
Browse files Browse the repository at this point in the history
  • Loading branch information
ystade committed Mar 3, 2025
1 parent 11ec487 commit ba95268
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/mqt-core/na/NAComputation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class NAComputation final : protected std::vector<std::unique_ptr<Op>> {
}
template <typename... Args>
auto emplaceInitialLocation(const Atom* atom, Args&&... loc) -> void {

Check warning on line 80 in include/mqt-core/na/NAComputation.hpp

View workflow job for this annotation

GitHub Actions / 🇨‌ Lint / 🚨 Lint

include/mqt-core/na/NAComputation.hpp:80:59 [cppcoreguidelines-missing-std-forward]

forwarding reference parameter 'loc' is never forwarded inside the function body
initialLocations.emplace(atom, Location(std::forward<Args>(loc)...));
initialLocations.emplace(atom, Location{std::forward<Args>(loc)...});
}
template <class T> auto emplaceBack(T&& op) -> const Op* {

Check warning on line 83 in include/mqt-core/na/NAComputation.hpp

View workflow job for this annotation

GitHub Actions / 🇨‌ Lint / 🚨 Lint

include/mqt-core/na/NAComputation.hpp:83:43 [cppcoreguidelines-missing-std-forward]

forwarding reference parameter 'op' is never forwarded inside the function body
return std::vector<std::unique_ptr<Op>>::emplace_back(
Expand Down

0 comments on commit ba95268

Please sign in to comment.