Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRC colorization #6

Open
anthonycorletti opened this issue Dec 9, 2024 · 8 comments · May be fixed by #7
Open

GRC colorization #6

anthonycorletti opened this issue Dec 9, 2024 · 8 comments · May be fixed by #7

Comments

@anthonycorletti
Copy link

I noticed that some text background washout happens with commands colorized by grc.

Ghostty's default is ok, but some themes like catppuccin make text with background color blocking really hard to read.

Default:
Screenshot_2024-11-27_at_11 13 52_AM

Catppuccin:
Screenshot_2024-11-27_at_11 14 11_AM

@uncenter uncenter linked a pull request Dec 9, 2024 that will close this issue
@uncenter
Copy link
Member

uncenter commented Dec 9, 2024

Can you try out the themes on the https://github.com/catppuccin/ghostty/tree/feat/ansi branch and let me know if it improves or fixes those issues you bring up?

@anthonycorletti
Copy link
Author

Looks like those are the colors I'm using. Still seeing the washout.

› cat /Applications/Ghostty.app/Contents/Resources/ghostty/themes/catppuccin-mocha
palette = 0=#45475a
palette = 1=#f38ba8
palette = 2=#a6e3a1
palette = 3=#f9e2af
palette = 4=#89b4fa
palette = 5=#f5c2e7
palette = 6=#94e2d5
palette = 7=#a6adc8
palette = 8=#585b70
palette = 9=#f37799
palette = 10=#89d88b
palette = 11=#ebd391
palette = 12=#74a8fc
palette = 13=#f2aede
palette = 14=#6bd7ca
palette = 15=#bac2de
background = 1e1e2e
foreground = cdd6f4
cursor-color = f5e0dc
selection-background = 585b70
selection-foreground = cdd6f4

@KevinNitroG
Copy link

The cursor on the char so hard to read
Image

Unlike other terms like

  • Alacritty

    Image

  • Kitty

    Image

@uncenter
Copy link
Member

The cursor on the char so hard to read

Already fixed in #10. Are you using the latest themes from this repository?

@uncenter uncenter reopened this Feb 10, 2025
@KevinNitroG
Copy link

The cursor on the char so hard to read

Already fixed in #10. Are you using the latest themes from this repository?

I just install ghostty from arch repo. May be it hasnt been updated into ghostty source code yet...? 😬

@uncenter
Copy link
Member

uncenter commented Feb 10, 2025

We don't have control over the default theme repository Ghostty uses (https://github.com/mbadolato/iTerm2-Color-Schemes). I would suggest using the custom theme installation method listed in the README instead (just updated the docs to not suggest using the default theme).

@KevinNitroG
Copy link

Alright I got it. But, why did you re open this issue?

@uncenter
Copy link
Member

You commented on this issue about general contrast issues with an unrelated text-under-cursor color problem. I mistakenly closed it, before remembering that this issue is about something else, so I reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants