Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45 add adc support for sixtron bus #46

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

Sokario
Copy link
Member

@Sokario Sokario commented Oct 25, 2024

Allow the user to define ADC thanks to zephyr,user in app.overlay:

#include <zephyr/dt-bindings/gpio/sixtron-header.h>

/ {
	zephyr,user {
		/* adjust channel number according to pinmux in board.dts */
		io-channels = <&sixtron_adc ADC1>;
	};
};

Then use the ADC as presented in ADC_dt zephyr example.

@Sokario Sokario linked an issue Oct 25, 2024 that may be closed by this pull request
@Sokario Sokario requested a review from a team October 25, 2024 09:34
Copy link
Member

@bperraudin bperraudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

I think we should only remove the indicated comments from the device tree, to present only what is necessary for the end user.

@Sokario Sokario requested a review from bperraudin October 30, 2024 10:48
@Sokario Sokario force-pushed the 45-add-adc-support-for-sixtron-bus branch from 0a2f9a5 to 2f02e49 Compare October 30, 2024 10:52
Copy link
Member

@bperraudin bperraudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bperraudin bperraudin merged commit e94082c into main Oct 30, 2024
2 checks passed
@bperraudin bperraudin deleted the 45-add-adc-support-for-sixtron-bus branch October 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ADC support for sixtron bus
2 participants