Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing zephyr,code for User Button in gpio-keys config #28

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add missing zephyr,code for User Button in gpio-keys config #28

merged 2 commits into from
Nov 25, 2024

Conversation

andiaye33
Copy link
Contributor

No description provided.

@andiaye33 andiaye33 added the bug Something isn't working label Nov 12, 2024
@andiaye33 andiaye33 requested a review from a team November 12, 2024 10:20
@andiaye33 andiaye33 self-assigned this Nov 12, 2024
@andiaye33 andiaye33 linked an issue Nov 12, 2024 that may be closed by this pull request
Missing zephyr,code input event code in gpio-key #26
Closed
clementlgl
clementlgl requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@clementlgl clementlgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for more readability, we should include zephyr/dt-bindings/input/input-event-codes.h

@clementlgl
Copy link
Contributor

@andiaye33 Can you squash commit and resolve conflict ? Thanks

@andiaye33 andiaye33 requested a review from clementlgl November 15, 2024 10:58
@andiaye33 andiaye33 marked this pull request as draft November 15, 2024 13:14
@andiaye33 andiaye33 force-pushed the 26-missing-zephyrcode-input-event-code-in-gpio-key branch from 62ca226 to 61579e4 Compare November 15, 2024 13:25
@andiaye33 andiaye33 marked this pull request as ready for review November 15, 2024 13:34
@clementlgl
Copy link
Contributor

@andiaye33 Commits are not squash 😕

@clementlgl clementlgl merged commit 854dabd into main Nov 25, 2024
2 checks passed
@clementlgl clementlgl deleted the 26-missing-zephyrcode-input-event-code-in-gpio-key branch November 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clementlgl clementlgl clementlgl approved these changes

Assignees

@andiaye33 andiaye33

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing zephyr,code input event code in gpio-key
2 participants
@andiaye33 @clementlgl