-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend Configuration IIa] Add dataset identification tools #569
Merged
CodyCBakerPhD
merged 40 commits into
main
from
new_backend_default_dataset_configuration
Nov 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
c4bca8a
port over tool function for defaults
CodyCBakerPhD 38a1fa3
modify iterator as well
CodyCBakerPhD a981068
factor out backend config stuff to other PR
CodyCBakerPhD 966592c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2df8c06
Merge branch 'new_backend_pydantic_backend_configuration_models' into…
CodyCBakerPhD 2e7af84
Update CHANGELOG.md
CodyCBakerPhD 85bc927
Update __init__.py
CodyCBakerPhD 8307156
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 87bee35
Merge branch 'new_backend_pydantic_backend_configuration_models' into…
CodyCBakerPhD 87d1116
Merge branch 'new_backend_pydantic_backend_configuration_models' into…
CodyCBakerPhD 13c9b37
use dataset_name in DatasetInfo; other debugs
b63161a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d55e2a2
remove comments
4b848b0
Merge branch 'new_backend_default_dataset_configuration' of https://g…
446d81d
fix conflict
CodyCBakerPhD 3c7cde8
remove unused typing
CodyCBakerPhD b845ac6
improve error message and fix import test
CodyCBakerPhD 5c7fb6b
add global static maps; further condense tests with parametrize
CodyCBakerPhD 91aab8c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 65eee6b
fix name
CodyCBakerPhD a0a4d07
Merge branch 'new_backend_default_dataset_configuration' of https://g…
CodyCBakerPhD 673e2f9
Apply suggestions from code review
CodyCBakerPhD 271660c
Merge branch 'main' into new_backend_default_dataset_configuration
CodyCBakerPhD 8630316
PR suggestions
CodyCBakerPhD f7e1be6
Update src/neuroconv/tools/nwb_helpers/_dataset_configuration.py
CodyCBakerPhD 46b8cdb
Merge branch 'main' into new_backend_default_dataset_configuration
CodyCBakerPhD 6f0806a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b07a541
add IO to dataset config names
CodyCBakerPhD 2bb867a
fix conflict
CodyCBakerPhD 89915ab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bfe1049
fix minimal test
CodyCBakerPhD 268e7e9
Merge branch 'new_backend_default_dataset_configuration' of https://g…
CodyCBakerPhD f1683fa
alter private method name
CodyCBakerPhD 185a69d
add extra tests
CodyCBakerPhD 6fad003
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 15d8aed
Merge branch 'main' into new_backend_default_dataset_configuration
h-mayorquin 4f668ec
Merge branch 'main' into new_backend_default_dataset_configuration
CodyCBakerPhD 5ce5914
add test for ragged tables; debug
CodyCBakerPhD 8350d2e
Merge branch 'new_backend_default_dataset_configuration' of https://g…
CodyCBakerPhD 3032755
adjust for cross-platform
CodyCBakerPhD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so how are these two guys differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular,
dynamic_table[column_name]
calls__get_item__
ondynamic_table
with keycolumn_name
, which defaultdict
behavior would return the value, but they adjust it to return downstream links so that you can do things likeunits["spike_times"][:]
and it returns the actual list of spikes shaped byunits x spikes_per_unit