Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected session_id by replacing invalid characters with underscores… #1227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anoushkajain
Copy link

@anoushkajain anoushkajain commented Feb 25, 2025

solves issue #1156

@anoushkajain anoushkajain marked this pull request as draft February 25, 2025 16:16
@alessandratrapani alessandratrapani self-requested a review February 25, 2025 16:20
@h-mayorquin
Copy link
Collaborator

Thanks for the draft @anoushkajain. Don't forget to add a test for it and ping me when you think is ready or you need any help with it.

@alessandratrapani alessandratrapani marked this pull request as ready for review February 27, 2025 15:13
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (fa8a16f) to head (5172c5e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/tools/data_transfers/_dandi.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   89.92%   89.91%   -0.02%     
==========================================
  Files         131      131              
  Lines        8411     8412       +1     
==========================================
  Hits         7564     7564              
- Misses        847      848       +1     
Flag Coverage Δ
unittests 89.91% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/tools/data_transfers/_dandi.py 20.93% <0.00%> (-0.50%) ⬇️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of creating more than one file given that dandi organize is meant to work across a set of many files. Let's do 4-5-6 or something like that.

Also, for the last bit of the test I think it is better to just be explicit instead of relying on a loop to make the error obvious and transparent.

What do you think? @alessandratrapani @anoushkajain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants