Support NUT-XX (signatures on quotes) for mint and wallet side #670
Conversation
cashu/mint/ledger.py
Outdated
| @@ -518,13 +520,15 @@ async def mint( | |||
| *, | |||
| outputs: List[BlindedMessage], | |||
| quote_id: str, | |||
| witness: Optional[str] = None, | |||
| ) -> List[BlindedSignature]: | |||
| """Mints new coins if quote with `quote_id` was paid. Ingest blind messages `outputs` and returns blind signatures `promises`. | |||
|
|
|||
| Args: | |||
| outputs (List[BlindedMessage]): Outputs (blinded messages) to sign. | |||
| quote_id (str): Mint quote id. | |||
| keyset (Optional[MintKeyset], optional): Keyset to use. If not provided, uses active keyset. Defaults to None. | |||
There was a problem hiding this comment.
| keyset (Optional[MintKeyset], optional): Keyset to use. If not provided, uses active keyset. Defaults to None. |
outdated
|
Nice work. One issue here is that |
|
I think we should move the file |
yea that was the idea. The alternative is keeping the private key separate but still storing it together with the quote in the DB. And then when we request the quote from DB also return the separate private key. |
cashu/wallet/wallet.py
Outdated
| @@ -424,13 +429,29 @@ async def request_mint(self, amount: int, memo: Optional[str] = None) -> MintQuo | |||
| Returns: | |||
| MintQuote: Mint Quote | |||
| """ | |||
| mint_quote_response = await super().mint_quote(amount, self.unit, memo) | |||
| privkey, pubkey = await self.get_quote_ephemeral_keypair() | |||
There was a problem hiding this comment.
Can we move get_quote_ephemeral_keypair also to nut19.py?
There was a problem hiding this comment.
So if we later want to add derivation from seed+counter functionality we might want to keep it inside the wallet class.
There was a problem hiding this comment.
In general depends on the state of the wallet so...
I think it should have two separate columns |
…ot correctly escaped + pass in NUT-19 keypair to `request_mint` `request_mint_with_callback`
|
I moved |
callebtc
changed the title
Adding support for NUT-19.
Main changes:
Common:
MintQuotehas two more optional fields namedprivkeyandpubkeynut19.pycontainsconstruct_message,sign_mint_quoteandverify_mint_quotePostMintQuoteRequesthas one more optional field namedpubkeyPostMintRequesthas one more optional field namedpubkeyMint:
PostMintQuoteRequestcontains apubkey, save the public key together with the quote andrequire a BIP340 signature from said public key on the mint request's quote id and blind messages.
PostMintQuoteRequestdoes not contain apubkeywhile Mint is configured to require it, reject the request.nut19and moved submodulenutsin it. (fixed all imports)Wallet:
pubkeyin thePostMintRequest.privkeyin the quote when saving it to DB.key, sign the quote id and the blinded message withkeyImplements: cashubtc/nuts#188