Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error codes for request verification #223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add error codes for request verification #223

wants to merge 1 commit into from

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Feb 7, 2025 •
edited
Loading

@thesimplekid thesimplekid force-pushed the input_output_error_codes branch from 794a210 to 2ab6537 Compare February 7, 2025 14:15
lollerfirst
lollerfirst approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@lollerfirst lollerfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this change.

@elnosh elnosh mentioned this pull request Feb 11, 2025
Closed
@lollerfirst lollerfirst mentioned this pull request Feb 13, 2025
Merged
elnosh
elnosh reviewed Feb 17, 2025
View reviewed changes
error_codes.md
Comment on lines +13 to +14
| 11009 | Inputs/Outputs of multiple units | [NUT-03][03], [NUT-04][04], [NUT-05][05] |
| 11010 | Inputs and outputs not of same unit | [NUT-03][03], [NUT-04][04], [NUT-05][05] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these 2 errors be just 1? It seems like 2 different wordings for the same error - that inputs/outputs have different units

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first one is inputs and outputs separately, the second one is inputs and outputs together.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, thanks

@elnosh elnosh mentioned this pull request Feb 17, 2025
Merged
@callebtc
Copy link
Contributor

@elnosh should we check gonuts as done?

@elnosh
Copy link
Contributor

elnosh commented Feb 20, 2025

@elnosh should we check gonuts as done?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnosh elnosh elnosh approved these changes

@callebtc callebtc callebtc approved these changes

@lollerfirst lollerfirst lollerfirst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thesimplekid @callebtc @elnosh @lollerfirst