Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pub properties from structs #606

Open
crodas opened this issue Feb 18, 2025 · 0 comments
Open

Remove pub properties from structs #606

crodas opened this issue Feb 18, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@crodas
Copy link
Contributor

crodas commented Feb 18, 2025

Follow up:

Originally posted by @thesimplekid in #564 (comment)

Remove all the pub from non-payload or config entries properties. Everywhere where they could be updated with consequences outside of their logic, they should be private and exposed with a getter or a Deref trait, with their log the update hidden in the struct.

@thesimplekid thesimplekid added the good first issue Good for newcomers label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants