Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix h2c #102

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix h2c #102

merged 1 commit into from
Feb 20, 2024

Conversation

gandlafbtc
Copy link
Collaborator

@gandlafbtc gandlafbtc commented Feb 16, 2024 •
edited
Loading

⚠️ This PR will affect the restore process of wallets that implement determinsitic secrets. Wallets that implement this PR will have to initiate a 'self-spend' of all ecash after upgrading, in order to ensure the ecash will be recoverable. ⚠️

Changes

  • change to new H2C function

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@gandlafbtc gandlafbtc changed the base branch from main to development February 19, 2024 08:51
KKA11010
KKA11010 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@KKA11010 KKA11010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

callebtc
callebtc approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LFG

@gandlafbtc gandlafbtc merged commit f7ffde4 into development Feb 20, 2024
3 checks passed
@gandlafbtc gandlafbtc deleted the fix-h2c branch February 20, 2024 03:00
@gandlafbtc gandlafbtc mentioned this pull request Feb 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKA11010 KKA11010 KKA11010 approved these changes

@callebtc callebtc callebtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gandlafbtc @KKA11010 @callebtc