Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tailscale option handling #14

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Improve tailscale option handling #14

merged 3 commits into from
Feb 14, 2025

Conversation

josh
Copy link
Collaborator

@josh josh commented Feb 13, 2025

Partially addresses #4.

@josh josh requested review from tnm and Copilot February 13, 2025 21:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

cmd/hubproxy/main.go:86

  • The new function viperReadFile should have test coverage to ensure it correctly handles file-prefixed values and errors.
func viperReadFile(key string) {

cmd/hubproxy/main.go:183

  • The new handling of Tailscale options (ts-authkey and ts-hostname) should have test coverage to ensure they are correctly read and used.
if authKey := viper.GetString("ts-authkey"); authKey != "" {

cmd/hubproxy/main.go:205

  • [nitpick] Reassigning the variable hostname could be confusing. Consider using a different variable name for the reassigned value.
hostname = status.Self.DNSName
Copy link
Contributor

@tnm tnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice.

@tnm tnm merged commit 35328e2 into main Feb 14, 2025
2 checks passed
@josh josh deleted the ts-config branch February 15, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants