feat: fix null bug for clientSecret in refreshToken #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves issue #47 by updating the `casdoor.refreshToken` function to handle `null` values for `clientSecret`. When `clientSecret` is `null`, the field is now excluded from the request body, avoiding type casting errors.
hsluoyz
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
# [1.8.0](v1.7.0...v1.8.0) (2025-01-22) ### Features * fix null bug for clientSecret in refreshToken ([#48](#48)) ([bedbc8a](bedbc8a))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #47
This PR addresses issue #47, where the
refreshTokenfunction fails whenclientSecretisnull. The root cause was the inclusion of anullvalue forclient_secretin the request body, leading to a type casting error. Thecasdoor.refreshTokenfunction has been updated to exclude theclient_secretfield when it isnull. This ensures proper handling of such cases and prevents runtime errors.