Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gclean should provide image/mask information #54

Open
Tracked by #48
schiebel opened this issue Jun 5, 2024 · 1 comment
Open
Tracked by #48

gclean should provide image/mask information #54

schiebel opened this issue Jun 5, 2024 · 1 comment
Assignees

Comments

@schiebel
Copy link
Contributor

schiebel commented Jun 5, 2024

To support multifield imaging where the imaging parameters could be in an outlier file or other locations, gclean should provide a member function (or functions) which allow for getting information needed for the GUI. The things I can think of now are:

  • path to residual
  • path to mask
  • initial values for all iteration etc. parameters for each image (maybe this is already available in the record returned by the next/anext functions?)
@Kitchi
Copy link

Kitchi commented Feb 26, 2025

Copying over @schiebel's comment from #47 :

@Kitchi the latest commit to casagui contains the reorganized GUI to support multiple fields. It should pass automask parameters to gclean.update. Currently it uses separate gclean objects to generate masks and to generate and update residuals for each field. This was done to allow for testing without the implementation of multifield support within gclean and hopefully done in a way that will make it easy to remove the extra gclean objects in the future. At the point, interactive clean will depend on a single gclean object to handle the multiple fields. However, doing this depends on support in gclean for:

parameter validation in __init__
access to paths to mask images
access to paths to residual images
access to initial values for automask parameters (displayed in GUI)
access to initial values for iteration parameters (displayed in GUI)

I can't think of other things that may be needed, but basically because the configuration comes from bespoke description files for outliers it makes the most sense for gclean to ingest parameters and the provide accessors needed for the initial configuration of the GUI elements (instead of now where InteractiveClean processes the parameters and gclean processes them separately).

A mustache template used to generate _gclean.py from tclean.xml should make it easy to validate the parameters passed to gclean.init and keep gclean in sync as tclean changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants