Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BIF-424] [BIF-428] [BIF-429] Adding new continuations concepts page #17

Merged
merged 13 commits into from
Oct 4, 2024
Merged

[BIF-424] [BIF-428] [BIF-429] Adding new continuations concepts page #17

merged 13 commits into from
Oct 4, 2024

Conversation

chongzluong
Copy link
Contributor

@chongzluong chongzluong commented Oct 3, 2024 •
edited
Loading

Overview

One of the most commonly used features is continuations, otherwise known as conditioning on past generations. Adding a page to the Concepts page to explain this a little further.

Testing

Used fern docs dev locally and also looked at the previous from the Fern Preview CI. Screenshots below:

Screenshot 2024-10-03 at 12 02 27 PM Screenshot 2024-10-03 at 11 44 06 AM Screenshot 2024-10-03 at 11 44 19 AM Screenshot 2024-10-03 at 12 02 32 PM

Blockers

Figuring out some Fern issues with audio assets. Worst case I'll host them on s3 or something as a stop-gap

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-a389bead-7565-4813-b41c-98da748ee058.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-4a3ffea9-d641-4f9a-8fc0-b2089a40085c.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-36fd7fc4-7310-406d-a6d0-997a6ad5cdbd.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-a7ec1cff-f80d-498d-9805-4827eb362447.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-3a3a4ad3-6a1d-4ea8-ba8f-363f23aed06c.docs.buildwithfern.com

@chongzluong chongzluong requested a review from kbrgl October 3, 2024 18:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-a2a691e6-4a1f-4932-a13a-62535030ef46.docs.buildwithfern.com

@chongzluong chongzluong changed the title [BIF-424] [BIF-429] Adding new continuations concepts page [BIF-424] [BIF-428] [BIF-429] Adding new continuations concepts page Oct 3, 2024
@chongzluong chongzluong requested a review from dariuskia October 3, 2024 19:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🌿 Preview your docs: https://cartesia-preview-53828db4-bdc7-49eb-9013-271889a3895c.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🌿 Preview your docs: https://cartesia-preview-1060a866-e084-4f82-9864-018671f92d11.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🌿 Preview your docs: https://cartesia-preview-0b84b144-2315-4c3c-be34-5a3e116e033b.docs.buildwithfern.com

brwa-cartesia
brwa-cartesia approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@brwa-cartesia brwa-cartesia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, feels a bit more casual than the rest of our docs but that seems ok for concepts

fern/concepts/continuations.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🌿 Preview your docs: https://cartesia-preview-51b6f4a3-2e16-4bb2-9984-37034b530517.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🌿 Preview your docs: https://cartesia-preview-0fd06c85-0d50-4d04-ae5b-b96f45d7d8f2.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🌿 Preview your docs: https://cartesia-preview-bdd024fd-068c-4894-94c7-340e8be49d25.docs.buildwithfern.com

@chongzluong chongzluong merged commit 258bf8e into main Oct 4, 2024
2 checks passed
@chongzluong chongzluong deleted the chongz--concepts--continuations branch October 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brwa-cartesia brwa-cartesia brwa-cartesia approved these changes

@kbrgl kbrgl Awaiting requested review from kbrgl

@dariuskia dariuskia Awaiting requested review from dariuskia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongzluong @brwa-cartesia