Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision session 1.1 and 1.2 #47

Merged
merged 5 commits into from
Feb 2, 2025

Conversation

KyriJanssen
Copy link
Collaborator

Added slides part 1.1
Revisions rmd files session 1.1 and 1.2

Added slides part 1.1
Revisions rmd files session 1.1 and 1.2
Copy link

github-actions bot commented May 7, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

Results of any additional workflows will appear here when they are done.

github-actions bot pushed a commit that referenced this pull request May 7, 2024
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KyriJanssen! I left some comments and suggestions.

@@ -317,6 +304,7 @@ download.file(
)

```
The data we just downloaded is data about country statistics, containing information on, for instance, GDP and life-expectancy. We will work with this data later this morning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would remove references to dayparts (e.g., "this morning") as the lesson should fit any other set-up (e.g., run in four afternoons) when run by others.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. 'later in the lesson' or 'in the following episodes' might work better? instructors can adapt wording for specific workshop.

episodes/01-intro-to-r.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
@cforgaci
Copy link
Collaborator

@alwil and/or @javisanmillan, can you please have a look at this PR? I will process and merge these at the end of the day on 31 January.

Copy link
Collaborator

@alwil alwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cforgaci , I've added a few comments - feel free to adapt or disregard. I agree with all your comments. Also, some of the changes seem to be made to fit the workshop setting, but I think this should be also a more general resource, used also for self-learning.

episodes/01-intro-to-r.Rmd Show resolved Hide resolved
@@ -317,6 +304,7 @@ download.file(
)

```
The data we just downloaded is data about country statistics, containing information on, for instance, GDP and life-expectancy. We will work with this data later this morning
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. 'later in the lesson' or 'in the following episodes' might work better? instructors can adapt wording for specific workshop.

episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
Co-authored-by: Aleksandra Ewa Wilczynska <alexandra.wilczynska@gmail.com>
github-actions bot pushed a commit that referenced this pull request Feb 1, 2025
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwil thanks for the review! I processed the suggestions and left some comments.

Optionally, you can update your slides in this PR.

@alwil @KyriJanssen @javisanmillan I will merge this as soon as the current comments and suggestions are processed.

episodes/01-intro-to-r.Rmd Show resolved Hide resolved
episodes/01-intro-to-r.Rmd Outdated Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Show resolved Hide resolved
episodes/02-data-structures.Rmd Outdated Show resolved Hide resolved
episodes/01-intro-to-r.Rmd Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwil @javisanmillan do you want to update the slides as well?

@cforgaci cforgaci removed the request for review from ClementineCttn February 1, 2025 22:21
Co-authored-by: Aleksandra Ewa Wilczynska <alexandra.wilczynska@gmail.com>
@cforgaci
Copy link
Collaborator

cforgaci commented Feb 2, 2025

@KyriJanssen, @fcjerome @javisanmillan @alwil, thanks for this PR. There were a few small things that were not solved, but I moved them into issues and we can take care of those after the workshop. This is ready to be merged.

@cforgaci cforgaci merged commit 6515ae4 into carpentries-incubator:main Feb 2, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants