-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision session 1.1 and 1.2 #47
Conversation
Added slides part 1.1 Revisions rmd files session 1.1 and 1.2
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. Results of any additional workflows will appear here when they are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KyriJanssen! I left some comments and suggestions.
episodes/01-intro-to-r.Rmd
Outdated
@@ -317,6 +304,7 @@ download.file( | |||
) | |||
|
|||
``` | |||
The data we just downloaded is data about country statistics, containing information on, for instance, GDP and life-expectancy. We will work with this data later this morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would remove references to dayparts (e.g., "this morning") as the lesson should fit any other set-up (e.g., run in four afternoons) when run by others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. 'later in the lesson' or 'in the following episodes' might work better? instructors can adapt wording for specific workshop.
@alwil and/or @javisanmillan, can you please have a look at this PR? I will process and merge these at the end of the day on 31 January. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cforgaci , I've added a few comments - feel free to adapt or disregard. I agree with all your comments. Also, some of the changes seem to be made to fit the workshop setting, but I think this should be also a more general resource, used also for self-learning.
episodes/01-intro-to-r.Rmd
Outdated
@@ -317,6 +304,7 @@ download.file( | |||
) | |||
|
|||
``` | |||
The data we just downloaded is data about country statistics, containing information on, for instance, GDP and life-expectancy. We will work with this data later this morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. 'later in the lesson' or 'in the following episodes' might work better? instructors can adapt wording for specific workshop.
Co-authored-by: Aleksandra Ewa Wilczynska <alexandra.wilczynska@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alwil thanks for the review! I processed the suggestions and left some comments.
Optionally, you can update your slides in this PR.
@alwil @KyriJanssen @javisanmillan I will merge this as soon as the current comments and suggestions are processed.
instructors/1-Intro-to-R-slides.qmd
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alwil @javisanmillan do you want to update the slides as well?
Co-authored-by: Aleksandra Ewa Wilczynska <alexandra.wilczynska@gmail.com>
@KyriJanssen, @fcjerome @javisanmillan @alwil, thanks for this PR. There were a few small things that were not solved, but I moved them into issues and we can take care of those after the workshop. This is ready to be merged. |
Added slides part 1.1
Revisions rmd files session 1.1 and 1.2