-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 24-diagnosing-issues-improving-robustness.md #376
Conversation
Corrected error where the automating pylint section creates a branch named `pylint-ci` but then merges `test-suite` back into `develop`. Now the merge back into `develop` is with the `pylint-ci` branch.
Likely related to #365 |
Also related to #383, which appears to have a different solution to the same issue if I understand it correctly. After discussing it with Aleks, we'll need to work out the best way forward after the material has transitioned to the new format which has become a priority. We'll recreate the PR after that. At least we're not short on solutions for this :) |
Thanks for the contribution @jreeve-nv and comments @steve-crouch As I detailed in this comment, this is actually solved if we just get rid of creation and mention of the @jreeve-nv I have pushed updates to your PR to reflect these comments. Will wait for another member of the maintainer team to approve before we go ahead and merge. |
Let's have a chat about this @bielsnohr next time we meet later this week - I am actually minded to have this work on a separate branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this suggested change to the branch instructions and it all works as expected.
Corrected error where the automating pylint section creates a branch named
pylint-ci
but then mergestest-suite
back intodevelop
. Now the merge back intodevelop
is with thepylint-ci
branch.