Minor fixes for web render #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's weird that percentages need escaping for HTML output, but either way there are two %s here escaped in different ways |
ailithewing
commented
Apr 2, 2024
|
Ah I missed the first one originally. Both should be correct now I think? |
|
I think it's the other way around and neither of them should be escaped, but I'd have to check the build locally tomorrow |
alanocallaghan
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
% only needs to be escaped for latex output, the complaint was actually that \% isn't a good escape sequence, and \\% would just produce \% in the output, not %.
Updated and changed the scree plot to be simpler code showing fewer PCs. The text was also out of sync with the plot (previously no red lines in plot but mentioned in text).
If you don't mind the changes then do merge
alanocallaghan
pushed a commit
that referenced
this pull request
Jan 31, 2025
…-for-web-render Minor fixes for web render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website build stopped working. I think due to a % symbol not escaped in the PCA episode?
Fixed in commit I think?