Skip to content

Commit

Permalink
Small cleanups.
Browse files Browse the repository at this point in the history
  • Loading branch information
alinas committed Feb 27, 2025
1 parent 605bcb1 commit c14ff91
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion toolchain/lower/file_context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ auto FileContext::Run() -> std::unique_ptr<llvm::Module> {
GetFunction(sem_ir().global_ctor_id()),
/*Priority=*/0);
}

return std::move(llvm_module_);
}

Expand Down Expand Up @@ -220,7 +221,6 @@ auto FileContext::BuildFunctionDecl(SemIR::FunctionId function_id,

// TODO nit: add is_symbolic() to type_id to forward to
// type_id.AsConstantId().is_symbolic(). Update call below too.

auto get_llvm_type = [&](SemIR::TypeId type_id) -> llvm::Type* {
if (!type_id.has_value()) {
return nullptr;
Expand Down
2 changes: 1 addition & 1 deletion toolchain/lower/function_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class FunctionContext {

// Returns a value for the given instruction.
auto GetValue(SemIR::InstId inst_id) -> llvm::Value* {
// TODO: if(specific_id_.has_value()) update inst_id first.
// TODO: if(specific_id_.has_value()) may need to update inst_id first.

// All builtins are types, with the same empty lowered value.
if (SemIR::IsSingletonInstId(inst_id)) {
Expand Down

0 comments on commit c14ff91

Please sign in to comment.