Add logger runtime dependency to fix warning on Ruby 3.4
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using sshkit on Ruby 3.4 causes the following warning to be printed: > warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. > You can add logger to your Gemfile or gemspec to silence this warning. To avoid this warning, and to allow sshkit to work on Ruby 3.5+, this commit adds the `logger` gem as a runtime dependency to sshkit.
mattbrictson
changed the title
logger runtime dependency to fix warning on Ruby 3.4
will-in-wi
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using sshkit on Ruby 3.4 causes the following warning to be printed:
To avoid this warning, and to allow sshkit to work on Ruby 3.5+, this commit adds the
loggergem as a runtime dependency to sshkit.