-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort Order Improvements for the Agents table #448
Open
val500
wants to merge
3
commits into
main
Choose a base branch
from
CERTTF-396
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−35
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,14 +17,18 @@ <h1 class="p-heading--3"> | |
<button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button> | ||
<button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button> | ||
</form> | ||
<table aria-label="Agents table" class="p-table--mobile-card"> | ||
<table aria-label="Agents table" class="p-table--mobile-card" id="agentsTable"> | ||
<thead> | ||
<tr> | ||
<th aria-sort="none" class="has-overflow" style="width: 40pt"></th> | ||
<!-- Added an empty header for the warning icon column --> | ||
<th aria-sort="none">Name</th> | ||
<th aria-sort="none">State</th> | ||
<th aria-sort="none">Updated At</th> | ||
<th aria-sort="none" class="has-overflow" style="width: 80pt" use-outcome-sort id="agentsOutcomeHeader"> | ||
<span class="p-tooltip--top-left" aria-describedby="tooltip"> | ||
<span class="p-tooltip__message" role="tooltip" id="tooltip">The number of consecutively successful / failed provisioning attempts</span> | ||
Outcome | ||
</span> | ||
</th> | ||
<th aria-sort="none" id="agentsNameHeader">Name</th> | ||
<th aria-sort="none" id="agentsStateHeader">State</th> | ||
<th aria-sort="none" id="agentsUpdatedAtHeader">Updated At</th> | ||
<th>Job ID</th> | ||
</tr> | ||
</thead> | ||
|
@@ -38,14 +42,18 @@ <h1 class="p-heading--3"> | |
<span class="p-tooltip__message" role="tooltip" id="tooltip">This agent has failed the last {{ | ||
agent.provision_streak_count }} provision attempts</span> | ||
</span> | ||
{{ agent.provision_streak_count }} | ||
<span class="provision-streak"> | ||
{{ agent.provision_streak_count }} | ||
</span> | ||
{% elif agent.provision_streak_type == "pass" and agent.provision_streak_count > 0 %} | ||
<span class="p-tooltip--right" aria-describedby="tooltip"> | ||
<i class="p-icon--success"></i> | ||
<span class="p-tooltip__message" role="tooltip" id="tooltip">This agent has passed the last {{ | ||
agent.provision_streak_count }} provision attempts</span> | ||
</span> | ||
{{ agent.provision_streak_count }} | ||
<span class="provision-streak"> | ||
{{ agent.provision_streak_count }} | ||
</span> | ||
Comment on lines
+45
to
+56
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you fix the indentation here? |
||
{% endif %} | ||
</td> | ||
<td><a href="/agents/{{ agent.name }}">{{ agent.name }}</a></td> | ||
|
@@ -56,4 +64,4 @@ <h1 class="p-heading--3"> | |
{% endfor %} | ||
</tbody> | ||
</table> | ||
{% endblock %} | ||
{% endblock %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, great work, I have one comment in regards to the icons. You should add the
p-table__cell--icon-placeholder
on theth
andtd
elements that have icons; this will make the icon display outside the columnSee https://vanillaframework.io/docs/base/tables#icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
td
element seems to be at line 38. I'm not sure how the icon placeholder behavior and the span and tooltip you have will interact with each other.testflinger/server/src/templates/agents.html
Line 38 in f8f32c3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also suggest you remove the
style="width: 80pt
on both theth
andtd
elements, as it is generally bad practice to hard-code these styles into elements, and a hard-coded width can lead to some "fun" results...