Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jwt_signing_key as a supported terraform variable #429

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

plars
Copy link
Contributor

@plars plars commented Dec 10, 2024

Description

We need to pull the jwt signing key from vault, but first we need it to be something that can be applied with terraform.

Resolved issues

N/A

Documentation

N/A - but it's got a good description in the terraform variables.tf

Web service API changes

N/A

Tests

None - won't do anything on it's own. The other piece of this will be to add it to certification ops and have it pull from vault.

@plars plars requested review from val500 and a team December 10, 2024 21:26
Copy link
Contributor

@val500 val500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plars plars merged commit bdd88ff into main Dec 10, 2024
1 check passed
@plars plars deleted the terraform-add-jwt-signing-key branch December 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants