chore: Add tests to publisher utils #5001
Conversation
Demo
Jenkins 
demos.haus ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import getSettingsFormData from "../getSettingsFormData"; | ||
|
|
||
| const settingsData = { | ||
| blacklist_countries: [], |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
|
|
||
| const settingsData = { | ||
| blacklist_countries: [], | ||
| blacklist_country_keys: "", |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| update_metadata_on_release: false, | ||
| visibility: "private", | ||
| visibility_locked: false, | ||
| whitelist_countries: ["GB"], |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| visibility: "private", | ||
| visibility_locked: false, | ||
| whitelist_countries: ["GB"], | ||
| whitelist_country_keys: "", |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| }; | ||
|
|
||
| const data = { | ||
| blacklist_countries: [], |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| update_metadata_on_release: false, | ||
| visibility: "private", | ||
| visibility_locked: false, | ||
| whitelist_countries: ["GB"], |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| visibility: "private", | ||
| visibility_locked: false, | ||
| whitelist_countries: ["GB"], | ||
| whitelist_country_keys: "", |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| territory_distribution_status: true, | ||
| unlisted: true, | ||
| visibility: true, | ||
| whitelist_country_keys: true, |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| expect(formData.get("snap_id")).toEqual("snap-id"); | ||
| expect(formData.get("private")).toEqual("private"); | ||
| expect(formData.get("territories")).toEqual("custom"); | ||
| expect(formData.get("territories_custom_type")).toEqual("whitelist"); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] whitelist may be insensitive, use allowlist instead
| expect(formData.get("private")).toEqual("private"); | ||
| expect(formData.get("territories")).toEqual("custom"); | ||
| expect(formData.get("territories_custom_type")).toEqual("whitelist"); | ||
| expect(formData.get("blacklist_countries")).toEqual(""); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
Done
Added tests for publisher utils
How to QA
All tests should pass (the inclusive naming check will fail)
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-18400