Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add relevant page titles to snap publisher pages #4999

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jan 28, 2025

Done

Added appropriate page titles for publisher pages and added an aria-live attribute to page headings to inform screen readers that the page has changed.

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18633

@webteam-app
Copy link

@codeEmpress1
Copy link
Contributor

LGTM!

@steverydz steverydz merged commit dfb854d into main Jan 28, 2025
11 checks passed
@steverydz steverydz deleted the WD-18633-fix-publisher-page-titles branch January 28, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants