New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make publisher pages 404 with no permissions #4998

Merged

steverydz merged 1 commit into main from WD-18600-show-404-for-metrics-on-snaps-with-no-permissions

Jan 28, 2025

Contributor

steverydz commented Jan 27, 2025 •

edited

Loading

Done

Make publisher pages 404 if the user doesn't have access to that snap

How to QA

Make sure you are signed in: https://snapcraft-io-4998.demos.haus/snaps
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/listing
Check that the page 404s
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/builds
Check that the page 404s
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/releases
Check that the page 404s
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/metrics
Check that the page 404s
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/publicise
Check that the page 404s
Go to https://snapcraft-io-4998.demos.haus/domotzpro-agent/settings
Check that the page 404s

Testing

This PR has tests
No testing required (explain why): Already has existing tests

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18600


          fix: Make publisher pages 404 with no permissions

8f23f23

webteam-app commented Jan 27, 2025

Demo

Jenkins

demos.haus

steverydz added Review: Code needed Review: QA needed labels

codeEmpress1 added Review: Code +1 Review: QA +1 and removed Review: Code needed Review: QA needed labels

codeEmpress1 approved these changes

View reviewed changes

steverydz merged commit fb64859 into main

11 checks passed

steverydz deleted the WD-18600-show-404-for-metrics-on-snaps-with-no-permissions branch

January 28, 2025 09:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: Code +1 Review: QA +1