Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (or silence) Sass warnings #4988

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Fix (or silence) Sass warnings #4988

merged 5 commits into from
Jan 21, 2025

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jan 20, 2025

Done

  • silences all sass warnings from dependencies (Vanilla)
  • silences all sass warnings related to import (they are not urgent and require quite significant changes, automatic migrator doesn't seem to work out of the box https://sass-lang.com/documentation/breaking-changes/import/)
  • silences warnings in webpack build as well (also from react-components and store-components)
  • updates relevant code around color and other built-in functions to use their latest versions

A follow-up was created to fix warnings upstream in store-components: WD-18313
A follow-up was created to potentially fix import warnings if time allows: WD-18312

How to QA

  • Check the build logs on CI
  • or pull the branch, run dotrun build
  • there should be no warnings thrown by SCSS build

Testing

  • This PR has tests
  • No testing required (explain why): this is a build config change

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18305

@webteam-app
Copy link

@bartaz bartaz marked this pull request as ready for review January 20, 2025 12:39
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! LGTM 👍

@bartaz bartaz merged commit 28f15ba into main Jan 21, 2025
11 checks passed
@bartaz bartaz deleted the sass-warnings branch January 21, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants