Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename publisher and brand store roots #4985

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jan 17, 2025

Done

Note: Requires #4984 to be merged first

Renamed the root files for publisher and brand store

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): No behavioural changes

@webteam-app
Copy link

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (b8b6b55) to head (177b617).
Report is 224 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4985       +/-   ##
===========================================
- Coverage   66.80%   53.01%   -13.79%     
===========================================
  Files         113      145       +32     
  Lines        3714     3320      -394     
  Branches      965      525      -440     
===========================================
- Hits         2481     1760      -721     
- Misses       1098     1449      +351     
+ Partials      135      111       -24     
Files with missing lines Coverage Δ
...er/pages/PublisherSettings/UnregisterSnapModal.tsx 90.00% <ø> (ø)

... and 165 files with indirect coverage changes

@steverydz steverydz force-pushed the rename-publisher-and-brand-store-roots branch from 177b617 to ab3c6ca Compare January 20, 2025 09:29
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit e20c8e6 into main Jan 20, 2025
11 checks passed
@steverydz steverydz deleted the rename-publisher-and-brand-store-roots branch January 20, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants