Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor brand store state management #4972

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Jan 13, 2025

Done

Refactored the brand store state management. The rationale is to keep relevant state together, for example all model atoms and selectors in one file rather than separated as they interact with each other, it keeps concerns in one place, and the components don't need to make the distinction between atoms and selectors.

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18026

@webteam-app
Copy link

@ilayda-cp
Copy link
Contributor

  • In the global store brand endpoint returns 404.
  • in the Fully included stores section there is an empty element
    Screenshot from 2025-01-14 12-14-20
  • looks like there is a small cut off in the select all checkbox and maybe buttons need more margin but idk if this is related with this PR.
    Screenshot from 2025-01-14 12-17-32

@ilayda-cp
Copy link
Contributor

ok i realized that none of those things related with your PR. They've already on main.

@steverydz steverydz merged commit 4f4559a into main Jan 14, 2025
11 checks passed
@steverydz steverydz deleted the WD-18026-create-brand-store-atoms-and-selectors branch January 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants