Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store components #4476

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update store components #4476

merged 1 commit into from
Dec 8, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Dec 8, 2023

Done

Updated store components

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-7853

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4476.demos.haus

@steverydz steverydz marked this pull request as ready for review December 8, 2023 13:30
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42e96d9) 79.81% compared to head (2a1966f) 79.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4476   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files         207      207           
  Lines       10469    10469           
  Branches      924      924           
=======================================
  Hits         8356     8356           
  Misses       1989     1989           
  Partials      124      124           
Flag Coverage Δ
javascript 68.41% <ø> (ø)
python 85.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@steverydz steverydz merged commit e738eb5 into canonical:main Dec 8, 2023
10 checks passed
@steverydz steverydz deleted the update-store-components branch December 8, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants