Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatible hidden check (bugfix) #1718

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Feb 11, 2025

Description

This change was not supposed to be backward incompatible. This fixes it, default is False as before the hidden_manifests change, no manifest was hidden

Resolved issues

Fixes: CHECKBOX-1735
Fixes: #1716

Documentation

N/A

Tests

I installed checkbox stable, that doesnt have this feature, and connected running the provided test plan. It didn't crash as in the bug report

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (9a81f3b) to head (b6e3cd0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files         372      372           
  Lines       40338    40338           
  Branches     6809     6809           
=======================================
  Hits        19816    19816           
  Misses      19799    19799           
  Partials      723      723           
Flag Coverage Δ
checkbox-ng 69.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for this quick patch!

@Hook25 Hook25 merged commit a51b37c into main Feb 12, 2025
50 checks passed
@Hook25 Hook25 deleted the make_hidden_manifests_bw_compatible branch February 12, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got KeyError: 'hidden' when going into the page to select manifest
2 participants