Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename zeebe:priority to zeebe:priorityDefinition #64

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: rename zeebe:priority to zeebe:priorityDefinition #64

merged 1 commit into from
Aug 8, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Aug 8, 2024

Closes #62

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 8, 2024
@Skaiir Skaiir requested review from panagiotisgts and barmac August 8, 2024 10:07
@Skaiir Skaiir marked this pull request as ready for review August 8, 2024 10:07
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 8, 2024
panagiotisgts
panagiotisgts reviewed Aug 8, 2024
View reviewed changes
Copy link

@panagiotisgts panagiotisgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding the renaming of the property, not a JS expert though.

barmac
barmac approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and release as a patch. The extension was not planned to look as in the initial implementation.

@barmac barmac merged commit 17cb0f0 into main Aug 8, 2024
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 8, 2024
@barmac barmac deleted the patch-zeebe-priority branch August 8, 2024 11:49
@barmac
Copy link
Collaborator

barmac commented Aug 8, 2024

Released as v1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panagiotisgts panagiotisgts panagiotisgts left review comments

@barmac barmac barmac approved these changes

Assignees

@Skaiir Skaiir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support priority definition for userTasks
3 participants
@Skaiir @barmac @panagiotisgts