Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zeebe:priority #63

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat: support zeebe:priority #63

merged 1 commit into from
Aug 7, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Aug 4, 2024

Closes #62

One part which wasn't 100% clear to me was whether we want to make it an integer or not. I saw that integers are very rare in general in the moddle and plenty of integer-y things are parsed as strings. Also priority is one of those things that could theoretically be either really.

So not sure, what do you think

Nevermind I read through some stuff and I saw we need to support feel, so string it is, undrafting this.

@Skaiir Skaiir requested a review from philippfromme August 4, 2024 22:59
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 4, 2024
@Skaiir Skaiir marked this pull request as ready for review August 4, 2024 23:14
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 4, 2024
@Skaiir Skaiir force-pushed the 62-zeebe-priority branch from 8a7ecbf to dff4c92 Compare August 4, 2024 23:38
@Skaiir Skaiir requested a review from barmac August 7, 2024 07:56
Copy link
Collaborator

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barmac barmac merged commit 1618ba1 into main Aug 7, 2024
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 7, 2024
@barmac barmac deleted the 62-zeebe-priority branch August 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support priority definition for userTasks
2 participants