-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement commit on match #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiicamundi
changed the title
feat: implement commit on match
draft: feat: implement commit on match
Sep 18, 2024
leiicamundi
changed the title
draft: feat: implement commit on match
feat: implement commit on match
Sep 18, 2024
leiicamundi
force-pushed
the
feature/auto-update-renovate-doc
branch
from
September 19, 2024 10:22
33e694f
to
740ad1e
Compare
leiicamundi
force-pushed
the
feature/auto-update-renovate-doc
branch
2 times, most recently
from
September 19, 2024 11:16
8ff9a17
to
defa60d
Compare
auto-merge was automatically disabled
September 19, 2024 12:30
Pull request was converted to draft
Langleu
reviewed
Sep 20, 2024
Langleu
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small thing I'd probably change as you already have a reuseable workflow with the same content
Langleu
approved these changes
Sep 20, 2024
leiicamundi
force-pushed
the
feature/auto-update-renovate-doc
branch
from
September 20, 2024 10:00
075e6cc
to
f8bbaa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an example of a successful modification made by the lint : 8e7613c
related to https://github.com/camunda/team-infrastructure-experience/issues/344
I also implemented yamlfmt in the PR + auto update of the GHA
A re-usable workflow has been added to the PR, an example of it being called: camunda/camunda-tf-eks-module#116 (this PR is dependant of the this one to be merged in order to have the version pinned on main)