feat(action): asdf install and cache strategy #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiicamundi
changed the title
Langleu
reviewed
Jan 31, 2025
| id: cache-key | ||
| shell: bash | ||
| run: | | ||
| WEEK_NUMBER="$(date +%V)" |
There was a problem hiding this comment.
why do we need to invalidate the cache on a weekly basis?
Langleu
reviewed
Jan 31, 2025
There was a problem hiding this comment.
just for understanding, the just file is completely decoupled from the asdf install tooling action, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new composite action that installs asdf, its plugins, and associated tools within a project while also managing its cache.
Cache invalidation occurs either when the
tool-versionsfile changes or on a weekly expiration basis.Another aspect concerns the maintenance of the previously used action. It heavily relies on JavaScript, whereas a few lines of Bash would suffice. For example, https://github.com/asdf-vm/actions/blob/master/install/main.js contains over 3,400 lines of code—far too complex for a simple tool installation. Moreover, the action has not been updated for two years.
Additionally, this composite action abstracts the cache logic, allowing us to control it from our central repository.